How do I get from the dashboard to the GitHub view of the PR Graphite Community #how-do-i

Join Slack

How do I get from the dashboard to the GitHub view...

# how-do-i

Vampire

06/01/2023, 8:01 PM

How do I get from the dashboard to the GitHub view of the PR?

Jacob Gold

06/01/2023, 8:02 PM

you can use the shortcut "G L" to copy the link to the GitHub URL to your clipboard

Vampire

06/01/2023, 8:05 PM

Sneaky, some questions for that: • that's not too convenient, is there not way to go to GH directly? • is it a bug or intended that this shortcut is not shown in the shortcut help?

Jacob Gold

06/01/2023, 8:07 PM

We link specifically to GitHub for some of the features that we don't yet show on the site, e.g. specific CI runs, raw files — it should show up in the shortcut help though! I'll fix that

Vampire

06/01/2023, 8:07 PM

In return,

G A

is shown but does not work

Vampire

06/01/2023, 8:07 PM

Pressing it just toggles the general info

Jacob Gold

06/01/2023, 8:09 PM

are you talking about this? I see the correct shortcut there

Vampire

06/01/2023, 8:09 PM

Oh, missed the scrollbar, sorry 😄

Vampire

06/01/2023, 8:10 PM

Hm, no, I did not miss the scrollbar, I just didn't see it. Maybe because I expected it at the other

G then

shortcuts

David Balatero

06/01/2023, 8:11 PM

can you say more about why you're hoping to jump to the Github view, just to get a better sense of what you wanted to do?

Vampire

06/01/2023, 8:11 PM

Hm, no, there are suddenly more shortcuts that were not there before when I looked at the help some minutes ago

Jacob Gold

06/01/2023, 8:12 PM

Maybe because I expected it at the other G then shortcuts

yeah, they're sorted by page — that shortcut only works on the PR page so it's down there

Vampire

06/01/2023, 8:12 PM

jump to next/previous thread and view upstack/downstack pull requests were also not there

Vampire

06/01/2023, 8:13 PM

can you say more about why you're hoping to jump to the Github view, just to get a better sense of what you wanted to do?

Not trusting Graphite yet (or maybe ever :-D) The canonical thing is still GitHub.

David Balatero

06/01/2023, 8:18 PM

anything specific you don't trust? (this helps us think about things to build or fix next 🙂 )

Vampire

06/01/2023, 8:19 PM

I'm a very sceptic person. 😄 Besides that, what I reported in #bug-reports 🙂

Cole Erickson

06/02/2023, 4:12 PM

Yeah +1, I’ve seen this requested a bunch. I pretty much always look at the GitHub view of the PR before merging because merging code has risks, and I’ve been using the GitHub interface for years, so I think there are things that I could catch there that I wouldn’t catch from Graphite. Even if Graphite is perfect, I don’t know that yet, and need time to build confidence in it. I also want to know what my coworkers who don’t use Graphite are going to see It seems like the web app is (somewhat understandably) designed to discourage using GitHub directly, but nevertheless it’s so important to me I will always work around it. I uninstalled the redirecting web extension and have just habituated the multiclick workflow — open triple dot menu, click copy link to GitHub button, new tab, paste, enter IMO there should just be a single click button. I promise it won’t stop me from using Graphite!

Jacob Gold

06/02/2023, 4:14 PM

Even though it won't stop you from using Graphite, we prefer to add a little bit of friction to the subconscious "oh, I'll just use GH" because we believe that in the long run we'll be able to collect better feedback about improving the Graphite code review experience. It's definitely something we are not doing lightly

Jacob Gold

06/02/2023, 4:14 PM

We believe that this will help us create the best product possible

Jacob Gold

06/02/2023, 4:14 PM

I know it's annoying — even we want to look at the PR on GH sometimes!

Jacob Gold

06/02/2023, 4:15 PM

fwiw, the chrome extension no longer automatically redirects you to Graphite, the latest version now adds a "View in Graphite" button to the GH page instead

Vampire

06/02/2023, 4:17 PM

Then the description needs to be updated. At least yesterday it still said it auto-redirects

Vampire

06/02/2023, 4:18 PM

Actually, a similar extension could be done for the reverse way, or could even be as simple as a user script that injects that option. :-)

Vampire

06/02/2023, 11:07 PM

And there we have it 🙂

Copy code

// ==UserScript==
// @name          Graphite -> GitHub
// @description	  Injects a button to go to GitHub PR page from Graphite PR details
// @author        Björn Kautler
// @version       1.0
// @match         <https://app.graphite.dev/*>
// @require       <https://code.jquery.com/jquery-3.7.0.slim.min.js>
// ==/UserScript==

(function() {

let observer = new MutationObserver((mutations) => {
    if ($(".pull-request").length == 0) return
    if ($("#go-to-github").length != 0) return
    $(".header__nav").prepend('<button id="go-to-github" type="submit" class="buttons__button buttons__button__style--solid buttons__button__size--default" style="margin-right: 5px; background-color: gray"><img src="<https://github.githubassets.com/pinned-octocat.svg>" width="100%" height="100%"/></button>')

    $("#go-to-github").click(() => {
        window.open(window.location.href.replace(/^https:\/\/app.graphite.dev\/github\/pr\/([^\/]+)\/([^\/]+)\/([^\/]+)(\/.*)?$/, '<https://github.com/$1/$2/pull/$3>'), '_blank')
        return false
    })
})
observer.observe(document.body, { childList: true, subtree: true, attributes: false, characterData: false })

})();

Vampire

06/02/2023, 11:11 PM

chrome_fsiOm6XHSw.gif

❤️ 1

😮 1

Vampire

06/08/2023, 9:40 PM

Here a better version that does not almost completely hide the search bar I was not aware of. Editing my post somehow does not work.

Copy code

// ==UserScript==
// @name          Graphite -> GitHub
// @description	  Injects a button to go to GitHub PR page from Graphite PR details
// @author        Björn Kautler
// @version       1.1
// @match         <https://app.graphite.dev/*>
// @require       <https://code.jquery.com/jquery-3.7.0.slim.min.js>
// ==/UserScript==

(function() {

let observer = new MutationObserver((mutations) => {
    if ($(".pull-request").length == 0) return
    if ($("#go-to-github").length != 0) return
    $(".header__nav").prepend('<button id="go-to-github" type="submit" class="buttons__button buttons__button__style--solid buttons__button__size--default" style="margin-right: 5px; background-color: gray; width: unset"><img src="<https://github.githubassets.com/pinned-octocat.svg>" width="100%" height="100%"/></button>')

    $("#go-to-github").click(() => {
        window.open(window.location.href.replace(/^https:\/\/app.graphite.dev\/github\/pr\/([^\/]+)\/([^\/]+)\/([^\/]+)(\/.*)?$/, '<https://github.com/$1/$2/pull/$3>'), '_blank')
        return false
    })
})
observer.observe(document.body, { childList: true, subtree: true, attributes: false, characterData: false })

})();

❤️ 1

Vampire

08/15/2023, 11:32 AM

Here an updated version, working with latest dashboard. The button does not blend in as nicely, as the button classes were renamed and I do not use them anymore to be more future-proof:

Copy code

// ==UserScript==
// @name          Graphite -> GitHub
// @description	  Injects a button to go to GitHub PR page from Graphite PR details
// @author        Björn Kautler
// @version       1.2
// @match         <https://app.graphite.dev/*>
// @require       <https://code.jquery.com/jquery-3.7.0.slim.min.js>
// ==/UserScript==

(function() {

let observer = new MutationObserver((mutations) => {
    if ($(".pull-request__description").length == 0) return
    if ($("#go-to-github").length != 0) return
    $(".header__nav").prepend('<button id="go-to-github" type="submit" style="margin-right: 5px; background-color: gray"><img src="<https://github.githubassets.com/pinned-octocat.svg>" width="16" height="16"/></button>')

    $("#go-to-github").click(() => {
        window.open(window.location.href.replace(/^https:\/\/app.graphite.dev\/github\/pr\/([^\/]+)\/([^\/]+)\/([^\/]+)(\/.*)?$/, '<https://github.com/$1/$2/pull/$3>'), '_blank')
        return false
    })
})
observer.observe(document.body, { childList: true, subtree: true, attributes: false, characterData: false })

})();

❤️ 1

Vampire

02/26/2024, 10:48 AM

Vampire

02/26/2024, 10:48 AM

Here again an updated version, adapted to latest dashboard:

Copy code

// ==UserScript==
// @name          Graphite -> GitHub
// @description	  Injects a button to go to GitHub PR page from Graphite PR details
// @author        Björn Kautler
// @version       1.3
// @match         <https://app.graphite.dev/*>
// @require       <https://code.jquery.com/jquery-3.7.0.slim.min.js>
// ==/UserScript==

(function() {

let observer = new MutationObserver((mutations) => {
    if ($("[data-testid='pull-request-description']").lentgh == 0) return
    if ($("#go-to-github").length != 0) return
    $(".dropdown-anchor").prepend('<button id="go-to-github" type="submit" style="margin-right: 5px; background-color: gray"><img src="<https://github.githubassets.com/pinned-octocat.svg>" width="16" height="16"/></button>')

    $("#go-to-github").click(() => {
        window.open(window.location.href.replace(/^https:\/\/app.graphite.dev\/github\/pr\/([^\/]+)\/([^\/]+)\/([^\/]+)(\/.*)?$/, '<https://github.com/$1/$2/pull/$3>'), '_blank')
        return false
    })
})
observer.observe(document.body, { childList: true, subtree: true, attributes: false, characterData: false })

})();

Cole Erickson

02/26/2024, 8:27 PM

most well-maintained random userscript award 🏆

🎉 1

37 Views

Open in Slack

Previous Next